Skip to content

Update INSTALL.rst. #11254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 24, 2018
Merged

Update INSTALL.rst. #11254

merged 2 commits into from
May 24, 2018

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented May 15, 2018

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

- Dedent the overindented bullet lists.
- Add a link for FreeType.
- Suggest `python -mpytest` instead of `pytest` to run the tests for the
  same reason as `python -mpip` is suggested (avoids invoking an
  out-of-venv pytest).
- Clarify the situation regarding pycairo/cairocffi (the former works
  for everything and is a requirement for gtk3 (unless you're using pgi,
  but in that case you're mostly on your own)).
@jklymak jklymak merged commit e04da0a into matplotlib:master May 24, 2018
@jklymak
Copy link
Member

jklymak commented May 24, 2018

I've merged, but you may want to check that my rebase fix was correct....

@anntzer
Copy link
Contributor Author

anntzer commented May 24, 2018

Can you point to the rebase commit?

@anntzer anntzer deleted the update-installrst branch May 24, 2018 18:43
@jklymak
Copy link
Member

jklymak commented May 24, 2018

Sorry did w the web interface so I guess it makes it as part of the merge commit? I think I did it right....

@anntzer
Copy link
Contributor Author

anntzer commented May 24, 2018

Looks fine to me...

@anntzer
Copy link
Contributor Author

anntzer commented May 24, 2018

Although the dependency on six should have been reremoved from that file.

@anntzer anntzer mentioned this pull request May 24, 2018
6 tasks
@QuLogic QuLogic added this to the v3.0.0 milestone Nov 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants