Remove commented-out code, unused imports #11272
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anntzer
reviewed
May 18, 2018
|
|
||
| tr = self._axis_artist_helper.get_axislabel_transform(self.axes) \ | ||
| + self.offset_transform | ||
|
|
||
| self.label = AxisLabel(0, 0, "__from_axes__", | ||
| color = "auto", #rcParams['axes.labelcolor'], |
There was a problem hiding this comment.
was likely intended as a comment? (unclear)
There was a problem hiding this comment.
In context, rcParams['axes.labelcolor'] was previously used as the color argument, and later replaced by "auto" (which IIRC does fall back to the rcParam if it needs to, but may also try other default behaviour).
So it's dead code, and if taken to be a comment it's misleading.
anntzer
reviewed
May 18, 2018
|
A lot of matplotlib predates pep8. Also, while that particular rule is good
to follow, in practice, we see a lot of misuse. It is the unfortunate
consequence of tab-completion-guided development...
…On Fri, May 18, 2018 at 11:05 PM, Zac Hatfield-Dodds < ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In lib/matplotlib/backends/backend_wxagg.py
<#11272 (comment)>
:
> from .backend_agg import FigureCanvasAgg
-from .backend_wx import (
- _BackendWx, _FigureCanvasWxBase, FigureFrameWx,
- NavigationToolbar2Wx as NavigationToolbar2WxAgg)
Via PEP8
<https://www.python.org/dev/peps/pep-0008/#public-and-internal-interfaces>
:
Imported names should always be considered an implementation detail. Other
modules must not rely on indirect access to such imported names unless they
are an explicitly documented part of the containing module's API
Other people "must not rely" on that working - if it becomes public API
just because they might anyway, we might as well give up now!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#11272 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AARy-BK4n3IE-iBLuaix3Kepvo4mbtKzks5tz4v1gaJpZM4UE4TH>
.
|
timhoffm
approved these changes
May 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The proper place for commented-out old code is in the version history tracked by
git, not the current source files. As well as commented lines, I removed extra newlines where they made the spacing of code inconsistent and potentially confusing. Unused imports are a similar anti-pattern, and unpythonic.The intention is that this set of changes makes the code easier to read, and thus makes contributing to Matplotlib slightly easier.