Re-remove six from INSTALL.rst. #11304
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also group the dependencies in 1) non-pip installable, 2) setup-time dependencies, 3) run-time dependencies (without actually marking the groups, that seems a bit overkill).
jklymak
approved these changes
May 24, 2018
|
Oh hmmm, this now borks the Mac build on master as well as back ports. Is that because of the changes here? |
|
Huh, it fixed itself ;-).... |
timhoffm
approved these changes
May 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The merge of #11254 crossed the removal of six, so re-remove six from INSTALL.rst.
Also group the dependencies in 1) non-pip installable, 2) setup-time
dependencies, 3) run-time dependencies (without actually marking the
groups, that seems a bit overkill).
PR Summary
PR Checklist