Reuse the noninteractivity warning from Figure.show in _Backend.show. #11305
+9
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the warning message "Matplotlib is currently using ..., which is a non-GUI backend, so cannot show the figure" and the (minor) associated logic (of catching NonGuiException) is duplicated between Figure.show and _Backend.show. Make the latter use the former, to deduplicate it.
e85e53c to
6cf8450
Compare
jklymak
approved these changes
May 25, 2018
timhoffm
approved these changes
May 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the warning message "Matplotlib is currently using ..., which
is a non-GUI backend, so cannot show the figure" and the (minor)
associated logic (of catching NonGuiException) is duplicated between
Figure.show and _Backend.show. Make the latter use the former, to
deduplicate it.
PR Summary
PR Checklist