Skip to content

Revert "Deprecate text.latex.unicode." #11345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 31, 2018

Conversation

tacaswell
Copy link
Member

Reverts #11255

This is causing a lot of spam on CI. Should be restored along with the internal clean up required.

@tacaswell tacaswell added this to the v3.0 milestone May 31, 2018
@anntzer
Copy link
Contributor

anntzer commented May 31, 2018

I'm almost certain that #11292 would fix the issue (per "Use matplotlib.style.context to restore the style at exit, as it relies on rc_context which is ultimately more efficient than rcParams.update as it skips revalidation"). Triggering a rebuild of that PR now to check.

Sorry for the disturbance.

@dstansby
Copy link
Member

I'm going to merge this since it will get rid of all the messages for now, sorry for not checking and merging the original PR.

@dstansby dstansby merged commit 230a251 into master May 31, 2018
@dstansby dstansby deleted the revert-11255-text.latex.unicode branch May 31, 2018 10:39
@anntzer anntzer mentioned this pull request Jun 5, 2018
6 tasks
@anntzer
Copy link
Contributor

anntzer commented Aug 28, 2018

I put back a better(?) version in https://github.com/matplotlib/matplotlib/pull/11381/files, would be nice to know how it is causing problems in holoviews (can you provide a repro?).
It's still in rcsetup.py given that, yes, we want people to still be able to access it but have access trigger a deprecation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants