Skip to content

Fix: issue PendingDeprecationWarnings when pending=True #11394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix: issue PendingDeprecationWarnings when pending=True #11394

wants to merge 1 commit into from

Conversation

timhoffm
Copy link
Member

@timhoffm timhoffm commented Jun 7, 2018

PR Summary

As indicated in #11387 (comment) we issue a MatplotlibDeprecationWarning even for warn_deprecated(..., pending=True). This should be a PendingDeprecationWarning instead. The PR fixes this bug.

@anntzer anntzer mentioned this pull request Jun 7, 2018
Merged
6 tasks
@timhoffm
Copy link
Member Author

timhoffm commented Jun 7, 2018

Withdrawn in favor of the more complete #11395

@timhoffm timhoffm closed this Jun 7, 2018
@timhoffm timhoffm deleted the pending-deprecation branch December 17, 2018 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@timhoffm