Various fixes to deprecated and warn_deprecated. #11395
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timhoffm
approved these changes
Jun 7, 2018
jklymak
approved these changes
Jun 21, 2018
- Make `pending=True` actually emit a PendingDeprecationWarning, as advertised, and make it incompatible with `removal`, which seems semantically reasonable (`removal` itself is a new API in 3.0 so that's not an API break). - Restore use of %-formatting instead of .format for the message formatting, to restore accidentally broken backcompat (which was never released). - Restore support for the `addendum` kwarg, whose effect had accidentally been removed. - The `@deprecated` decorator has always ignored `obj_type` (forcefully overwriting it with the type of whatever is actually being decorated) so we may as well make it not support `obj_type` at all. - Remove a Py2 branch.
QuLogic
approved these changes
Jun 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make
pending=Trueactually emit a PendingDeprecationWarning, asadvertised, and make it incompatible with
removal, which seemssemantically reasonable (
removalitself is a new API in 3.0 sothat's not an API break).
Restore use of %-formatting instead of .format for the message
formatting, to restore accidentally broken backcompat (which was
never released).
Restore support for the
addendumkwarg, whose effect hadaccidentally been removed.
The
@deprecateddecorator has always ignoredobj_type(forcefullyoverwriting it with the type of whatever is actually being decorated)
so we may as well make it not support
obj_typeat all.Remove a Py2 branch.
(I noticed that @timhoffm just beat me to it in #11394 but this PR does a lot more.)
See #11387 (comment).
PR Summary
PR Checklist