Skip to content

Autogenerate credits.rst #11399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 9, 2018
Merged

Conversation

timhoffm
Copy link
Member

@timhoffm timhoffm commented Jun 7, 2018

PR Summary

This adds a script that automatically generates credits.rst with all the contributors in the git repository.
As a checkup, that the auto-generated credits.rst does not miss someone listed in the previously manually maintained list, I've regenerated the file. Usually, it will be to run the script once before a release.

@timhoffm timhoffm added this to the v3.0 milestone Jun 7, 2018
Ilya Flyamer,
ImSoErgodic,
Importance of Being Ernest,
ImportanceOfBeingErnest,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ImportanceOfBeingErnest which one of these do you prefer? (this just needs to be added as an entry in the .mailmap file)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the one without spaces is better, it makes it more obvious that this is a username, and not a user name.

Patrick Chen,
Patrick Marsh,
Paul,
Paul Barret,
Paul G,
Paul Ganssle,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Paul G (just above) is Paul Ganssle, please add an entry to the mailmap (see e.g. git help shortlog).

Ben Cohen,
Ben Gamari,
Ben Keller,
Ben Root,
Benedikt Daurer,
Benedikt J. Daurer,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mailmap this

Devashish Deshpande,
Diego Mora Cespedes,
Dietmar Schwertberger,
DietmarSchwertberger,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mailmap

JulianCienfuegos,
Julien L,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's Julien Lhermitte (just below), see https://github.com/matplotlib/matplotlib/pull/8455/commits.

Matthew Brett,
Matthew Emmett,
Matthew Newville,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as Matt Newville

Truong Pham,
Tuan,
Tuan Dung Tran,
Tuan333,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 3 "Tuan" should be mailmap'd.

Zac Hatfield-Dodds,
Zac-HD,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mailmap with Zac Hatfield-Dodds

yinleon,
zhangeugenia,
zhoubecky,
Élie Gouzien
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something based on locale.strcoll should sort this properly at "E".

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

locale.strcoll would need a sorted(cmp=) which was recently removed. Tried with contributors.sort(key=locale.strxfrm) but that does not work for some reason.

burrbull,
butterw,
cammil,
captainwhippet,
castany,
cclauss,
cgohlke,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Christoph Gohlke

marky,
masamson,
mattip,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Matti Picus

nwin,
ob,
patniharshit,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Harshit Patni

@timhoffm timhoffm force-pushed the autogenerate-credits-rst branch from 4c5512a to 5f94e44 Compare June 9, 2018 09:48
@NelleV
Copy link
Member

NelleV commented Jun 9, 2018

Thanks @timhoffm !

@NelleV NelleV merged commit e03ced8 into matplotlib:master Jun 9, 2018
@timhoffm timhoffm deleted the autogenerate-credits-rst branch June 9, 2018 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants