Properly position markers in step plots. #11407
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While it may appear costly to recache the path at every draw, this only occurs when using step plots with markers (a relatively rare case) and is still better than before the bug was introduced, when step plots used to need to be recomputed at every draw, regardless of whether markers are present.
timhoffm
approved these changes
Jun 10, 2018
|
There seem to be a conflict, please backport manually |
tacaswell
added a commit
to tacaswell/matplotlib
that referenced
this pull request
Aug 4, 2018
FIX: Properly position markers in step plots.
Conflicts:
lib/matplotlib/tests/test_lines.py
- conflict due to adding imports around (removed on master)
__future__ and six
tacaswell
pushed a commit
to tacaswell/matplotlib
that referenced
this pull request
Aug 5, 2018
This context manager was added to master in 690b213 via matplotlib#10314. We do not want to backport that entire commit, however the backport of matplotlib#11407 requires this context manger. It is private and self contained to low-risk to backport
|
backported to v2.2.x as 6133a7d |
This was referenced Jun 4, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11031.
While it may appear costly to recache the path at every draw, this only
occurs when using step plots with markers (a relatively rare case) and
is still better than before the bug was introduced (#6497), when step plots used
to need to be recomputed at every draw, regardless of whether markers
are present.
PR Summary
PR Checklist