-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
DOC: point align-ylabel demo to new align-label functions #11424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
097ad89
to
2fecd9b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many examples indeed lack proper cross linking to similar/opposite/related cases. This is a step in the right direction.
I didn't introduce that! sphinx-gallery maybe? EDIT: WRT the second blue box, I think its justified - the new methods are much easier for most uses... |
I’d rather have See also sections below the code. Having it up the is like saying “I’ll show you how to do alignment, but first you should look at these alternative ways. Then again the referenced method is the simpler more standard case, which should come first. The best solution would be to rewrite the example: First show a simple ˋalign_ylabel()ˋ example, then show the current code in case someone needs more control. But I do not necessarily require this as part of this PR. Mentioning ˋalign_ylabel()ˋ is an improvement already. |
Well ok fair enough. On phone and can’t label but I agree that combining the examples is a better solution. So please don’t merge until I do that. |
7807912
to
9adb067
Compare
3c27acc
to
0edc77c
Compare
0edc77c
to
07501bd
Compare
@timhoffm are the changes ok? If so, we can merge... |
There seem to be a conflict, please backport manually |
Not a big deal to bother w/ backport... Thanks @timhoffm! |
PR Summary
https://matplotlib.org/gallery/pyplots/align_ylabels.html#sphx-glr-gallery-pyplots-align-ylabels-py shows a hard way to do whats in https://matplotlib.org/gallery/subplots_axes_and_figures/align_labels_demo.html#sphx-glr-gallery-subplots-axes-and-figures-align-labels-demo-py
The hard way is potentially useful, but the easy way should at least be referenced.