-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Doc markersupdate #11437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doc markersupdate #11437
Conversation
lib/matplotlib/markers.py
Outdated
Also see the :doc:`/gallery/text_labels_and_annotations/stix_fonts_demo`. | ||
|
||
Integer numbers from ``0`` to ``11`` create lines and triangles. Those are | ||
equally accessible via capitalied variables, like ``CARETDOWNBASE``. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
capitalized?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really nice - I love the viz of each marker in the docs and the wording is definitely improved. I'm +1 on merge once travis is happy unless other folks find anything obviously wrong
0db1b0b
to
0b6942b
Compare
0b6942b
to
354fa7d
Compare
Not sure what the problem of travis-ci is; it looks like it doesn't like itself rather than not liking this PR. |
I gave it a restart to see if that fixes things |
It didn't. Something is generally going wrong with the ci tests currently, other PRs are affected by the same issue. |
Merged; I don't think the CI problems are here... |
🎉 |
``"H"`` |m16| hexagon2 | ||
``"+"`` |m17| plus | ||
``"x"`` |m18| x | ||
``"X"`` |m21| x (filled) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ImportanceOfBeingErnest
This should have been |m24|
rather than |m21|
, right?
Look for example for "x_filled" in the output of the following script, adapted from yours:
from matplotlib.lines import Line2D
markers= dict((k,v) for k,v in Line2D.markers.items())
markers.update({"$f$" : "mathtext"})
for i, (k, v) in enumerate(markers.items()):
if v=="nothing":
continue
print("{:02d}".format(i), k, v)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Absolutely. Thanks for spotting this. It should be fixed by #11545.
PR Summary
Closes #7342 and closes #8556.
#7342 lists a few things to improve about the
matplotlib.markers
documenation.This PR fixes those. In particular it
The marker table will look like
For completeness/reproducibility, here is the code to produce the images:
PR Checklist