ENH: make subplot reuse gridspecs if they fit #11441
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Right now, if we call
The gridspecs will be different. Thats unfortunate, because there is no reason for these two subplots to not share the same gridspec, and if they do, then constrained_layout will work with them. Note this change will mean that many calls to
pyplot.subplot
andpyplot.subplot2grid
will now work withconstrained_layout=True
as well.This PR changes that so they two subplots use the same gridspec.
Note The more fine-grained subplot call must come first, or the grid specs will not "fit", so this is pretty simple minded. However, the PR doesn't make things worse, it just makes two gridspecs like it did before. i.e. if we switch the order of the calls we get two gridspecs:
PR Checklist