Skip to content

Search $CPATH for include directories #11457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 19, 2018
Merged

Conversation

NickRF
Copy link
Contributor

@NickRF NickRF commented Jun 18, 2018

Searches the contents of the CPATH environment variable (alongside existing CPLUS_INCLUDE_PATH variable) when determining include directories during setup.

This fixes FreeType library detection when installing via Spack.

Copy link
Member

@jklymak jklymak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems reasonable to me, but it'd be good if it passed the 3.6 test, and if someone more familiar w/ the environment variables had a quick look EDIT: the 3.6 error looks to have been flakeyness on the CI not this PR

@dstansby dstansby added this to the v3.0 milestone Jun 19, 2018
@dstansby dstansby merged commit 4299756 into matplotlib:master Jun 19, 2018
NickRF added a commit to NickRF/spack that referenced this pull request Jun 20, 2018
Adds patch to add $CPATH to locations searched for FreeType header file

Patch has been upstreamed:
matplotlib/matplotlib#11457
adamjstewart pushed a commit to spack/spack that referenced this pull request Sep 4, 2018
* py-matplotlib: Add patch to fix FreeType library detection

Adds patch to add $CPATH to locations searched for FreeType header file

Patch has been upstreamed:
matplotlib/matplotlib#11457

* py-matplotlib: Add patch to fix FreeType library detection

* Make patch only apply to versin 2.2.2 (as already upstreamed)
* Fix flake8 format issue

* py-matplotlib: add range to freetype patch

* py-matplotlib: whitespace
anderson2981 pushed a commit to anderson2981/spack that referenced this pull request Sep 7, 2018
* py-matplotlib: Add patch to fix FreeType library detection

Adds patch to add $CPATH to locations searched for FreeType header file

Patch has been upstreamed:
matplotlib/matplotlib#11457

* py-matplotlib: Add patch to fix FreeType library detection

* Make patch only apply to versin 2.2.2 (as already upstreamed)
* Fix flake8 format issue

* py-matplotlib: add range to freetype patch

* py-matplotlib: whitespace
ptbremer pushed a commit to ptbremer/spack that referenced this pull request Oct 12, 2018
* py-matplotlib: Add patch to fix FreeType library detection

Adds patch to add $CPATH to locations searched for FreeType header file

Patch has been upstreamed:
matplotlib/matplotlib#11457

* py-matplotlib: Add patch to fix FreeType library detection

* Make patch only apply to versin 2.2.2 (as already upstreamed)
* Fix flake8 format issue

* py-matplotlib: add range to freetype patch

* py-matplotlib: whitespace
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants