Skip to content

Use pip requirements files for travis build #11483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 22, 2018

Conversation

dstansby
Copy link
Member

Personally I think this makes things clearer and easier to organise, instead of having lots of environment variables in the .travis.yml file. It should also make it easier to reproduce the pip dependencies locally. Am happy for this not to be merged if there are reasons not to do this though!

This adds a

  • Requirements file for all the travis builds
  • Extra requirements for the py36 build
  • Version file for the py35 minimum version build

@anntzer
Copy link
Contributor

anntzer commented Jun 22, 2018

I would rather at least put the "generic" test dependencies into an extras_require. Would probably also just get rid of the dependency on pytest-timeout (which was the cause of some recent changes) as in our case it's just a matter of calling faulthandler.dump_traceback_later(300, exit=False) which can easily be done in a local plugin.
(I don't feel that strongly about it, but I never really liked requirement files and feel that extra requires are better suited; for example, the latter are directly accessible by pip through PyPI, but not the former.)

@tacaswell tacaswell added this to the v3.0 milestone Jun 22, 2018
@tacaswell
Copy link
Member

👍 in principle. I like that you can now install the dependencies locally with out having to read the travis flie.

Lets punt on mucking with setup.py for now.

@NelleV
Copy link
Member

NelleV commented Jun 22, 2018

Thanks @dstansby ! That's going to help maintainability.

@NelleV NelleV merged commit 61a576b into matplotlib:master Jun 22, 2018
@dstansby dstansby deleted the travis_req_files branch June 23, 2018 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants