Bump pgi requirement to 0.0.11.2. #11504
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jklymak
previously approved these changes
Jul 3, 2018
Ooops, I guess this should pass the gtk test before it gets approved...
37fde73 to
ae85dad
Compare
|
Now it's working... |
anntzer
commented
Jul 4, 2018
| # also necessary on gtk3 and wx, where a direct call to key_press_event("q") | ||
| # from draw_event causes breakage due to the canvas widget being deleted too | ||
| # early. Also, gtk3 redefines key_press_event with a different signature, so | ||
| # we directly invoke it from the superclass instead. |
This version of pgi fixes a bug in the calling of callbacks, which affected timers in the GTK3 backends. Remove a special-casing in the test suite accordingly (in test_backends_interactive.py).
tacaswell
approved these changes
Jul 8, 2018
|
attn @sandrotosi Is this going to be a problem for debian? |
|
I don't actually recommend anyone to use pgi (nor does the pgi maintainer); the only real use case is to be installable on Travis with dockerizing the entire build. |
|
thanks @tacaswell for pinging me! from the project description pgi is 'GTK+ / GObject Introspection Bindings for PyPy' - in debian we currently dont provide pypy packages for mpl, and we already have cairocffi in our dependencies, so i think we should be good here |
jklymak
approved these changes
Jul 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This version of pgi fixes a bug in the calling of callbacks, which
affected timers in the GTK3 backends. Remove a special-casing in the
test suite accordingly (in test_backends_interactive.py).
(See pygobject/pgi#48.)
PR Summary
PR Checklist