Skip to content

Raise ImportError on failure to import backends. #11519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 28, 2018
Merged

Raise ImportError on failure to import backends. #11519

merged 1 commit into from
Jun 28, 2018

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Jun 27, 2018

Breaking down #9795 into smaller pieces.
Marking as release critical following #9795.

This will make backend fallback logic easier (try a backend, if it
raises ImportError, move to the next one).

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer
Raise ImportError on failure to import backends.
5a01cb8 
This will make backend fallback logic easier (try a backend, if it
raises ImportError, move to the next one).
@anntzer anntzer added the Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. label Jun 27, 2018
@anntzer anntzer added this to the v3.0 milestone Jun 27, 2018
dstansby
dstansby approved these changes Jun 28, 2018
View reviewed changes
Copy link
Member

@dstansby dstansby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 works as expected for the OSX backend on a non-framework build, someone else should probably check that gtk3 behaves as expected

@tacaswell tacaswell merged commit 939c311 into matplotlib:master Jun 28, 2018
@anntzer anntzer deleted the backendloadfailure branch June 28, 2018 21:49
@tacaswell tacaswell mentioned this pull request Jul 8, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dstansby dstansby dstansby approved these changes

Assignees
No one assigned
Labels
Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@anntzer @dstansby @tacaswell