Skip to content

More simplifications to FreeType setup on Windows. #11570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 4, 2018
Merged

More simplifications to FreeType setup on Windows. #11570

merged 1 commit into from
Jul 4, 2018

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Jul 4, 2018

Another small chunk of #11235.

  • VS2010 is now always True -> perform constant folding.
  • Remove unused fixproj, tar_extract, zip_extract, DEPSSRC, DEPSBUILD,
    PYVER.
  • prepare_build_cmd is only called once so no need to cache VCVARSALL.
  • Remove unused imports.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer anntzer force-pushed the morefreetypewindows branch from 3f6e7b9 to 62085da Compare July 4, 2018 14:58
@anntzer
More simplifications to FreeType setup on Windows.
a1a04fa 
- VS2010 is now always True -> perform constant folding.
- Remove unused fixproj, tar_extract, zip_extract, DEPSSRC, DEPSBUILD,
  PYVER.
- prepare_build_cmd is only called once so no need to cache VCVARSALL.
- Remove unused imports.
@anntzer anntzer force-pushed the morefreetypewindows branch from 62085da to a1a04fa Compare July 4, 2018 16:00
jklymak
jklymak approved these changes Jul 4, 2018
View reviewed changes
Copy link
Member

@jklymak jklymak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it works... Failed test is just the mac wx stuff...

@timhoffm timhoffm merged commit 7544c46 into matplotlib:master Jul 4, 2018
@anntzer anntzer deleted the morefreetypewindows branch July 4, 2018 19:14
@anntzer anntzer mentioned this pull request Jul 4, 2018
Merged
6 tasks
@QuLogic QuLogic added this to the v3.0 milestone Jul 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jklymak jklymak jklymak approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
Build OS: Microsoft
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@anntzer @jklymak @timhoffm @QuLogic