Skip to content

DOC: move a couple of GridSpec examples into subplots gallery #11619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 13, 2018
Merged

DOC: move a couple of GridSpec examples into subplots gallery #11619

merged 2 commits into from
Jul 13, 2018

Conversation

jklymak
Copy link
Member

@jklymak jklymak commented Jul 10, 2018 •
edited
Loading

PR Summary

There were no examples of using GridSpec in the subplots, axes, and figures gallery.

  • add a constrained_layout demo, and lightly modify the tight_layout demo

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@jklymak jklymak added this to the v2.2-doc milestone Jul 10, 2018
@jklymak
Copy link
Member Author

jklymak commented Jul 10, 2018

See here: https://11418-1385122-gh.circle-artifacts.com/0/home/circleci/project/doc/build/html/gallery/index.html#subplots-axes-and-figures

@jklymak jklymak force-pushed the doc-rearrange-gridspec-examples branch 3 times, most recently from 1299c1b to ed49d1c Compare July 10, 2018 21:18
timhoffm
timhoffm approved these changes Jul 10, 2018
View reviewed changes
examples/subplots_axes_and_figures/demo_tight_layout.py Outdated
Resizing axes with tight layout
===============================

Tight layout (`~.figure.Figure.tight_layout`) attempts to resize subplots in
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any reason not to do simply

`~.figure.Figure.tight_layout` attempts  to ...

examples/subplots_axes_and_figures/gridspec_multicolumn.py Outdated
Using Gridspec to make multi-column/row subplot layouts
=======================================================

`~.matplotlib.gridspec.GridSpec` is a flexible way to layout
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

`.GridSpec` should be sufficient.

@jklymak jklymak force-pushed the doc-rearrange-gridspec-examples branch from ed49d1c to aab834c Compare July 11, 2018 04:21
NelleV
NelleV approved these changes Jul 13, 2018
View reviewed changes
Copy link
Member

@NelleV NelleV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jklymak !

@NelleV NelleV merged commit ad69e89 into matplotlib:master Jul 13, 2018
@lumberbot-app
Copy link

lumberbot-app bot commented Jul 13, 2018

There seem to be a conflict, please backport manually

@jklymak jklymak deleted the doc-rearrange-gridspec-examples branch July 13, 2018 21:10
@dstansby dstansby modified the milestones: v2.2-doc, v3.0-doc Jun 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NelleV NelleV NelleV approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
v3.0-doc
Development

Successfully merging this pull request may close these issues.
4 participants
@jklymak @NelleV @timhoffm @dstansby