Minor docstring fixes #11626
Merged
Minor docstring fixes #11626
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuLogic
approved these changes
Jul 11, 2018
lib/matplotlib/pyplot.py
Outdated
| @@ -575,6 +575,7 @@ def gcf(): | |||
|
|
|||
|
|
|||
| def fignum_exists(num): | |||
| """Return whether the figure with the given number exists.""" | |||
There was a problem hiding this comment.
Technically figure numbers don't need to be numbers; I'm not sure how to convey that succinctly in the one line though.
There was a problem hiding this comment.
We could use id instead of num. Would it be permissible to change the argument name as well? Technically, that would be a breaking change if someone used it as a kwarg. However, thats rather unlikely, as there is no good reason to do it here?
lib/matplotlib/pyplot.py
Outdated
| @@ -591,6 +592,11 @@ def get_figlabels(): | |||
|
|
|||
|
|
|||
| def get_current_fig_manager(): | |||
| """ | |||
| Return the figure manager of he active figure. | |||
c6955f6 to
d2ec53b
Compare
|
Thanks @timhoffm ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary