Don't flush file object opened for reading #11636
Merged
+8
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ct opened for reading, because it returns an error on BSD systems, with the end result that "import matplotlib.pyplot" fails with the error message "TypeError: First argument must be a path or file object reading bytes".
timhoffm
approved these changes
Jul 11, 2018
|
Thanks @gson1703 ! |
QuLogic
added a commit
that referenced
this pull request
Jul 11, 2018
…636-on-v2.2.x Backport PR #11636 on branch v2.2.x
tacaswell
added a commit
to tacaswell/matplotlib
that referenced
this pull request
Aug 8, 2018
Following up on matplotlib#11635 / matplotlib#11636 another bug was found. PY3K is always defined in mplutils.h so we were always going through the nominally (py3 + pypy) only code path on all version of python which exposes an issue with fflush (eventually called by py27 internals) on BSD systems.
This was referenced Aug 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't attempt to flush a file object opened for reading, because on BSD systems, it results in an error return from fflush(), with the end result that "import matplotlib.pyplot" fails with the error message "TypeError: First argument must be a path or file object reading bytes".
Closes #11635.