Skip to content

Remove unused C++ code. #11676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 17, 2018
Merged

Remove unused C++ code. #11676

merged 1 commit into from
Jul 17, 2018

Conversation

QuLogic
Copy link
Member

@QuLogic QuLogic commented Jul 17, 2018

PR Summary

This code appears to be unused. It's not exposed externally, so delete it.

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • [N/A] New features are documented, with examples if plot related
  • [N/A] Documentation is sphinx and numpydoc compliant
  • [N/A] Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • [N/A] Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer
Copy link
Contributor

anntzer commented Jul 17, 2018

It appears that some of it used to be used by the native OSX backend before it switched to using Agg in #6178.

@jklymak jklymak merged commit 55de317 into matplotlib:master Jul 17, 2018
@jklymak
Copy link
Member

jklymak commented Jul 17, 2018

Thanks @QuLogic !

@tacaswell tacaswell added this to the v3.0 milestone Jul 17, 2018
@QuLogic QuLogic deleted the delete-unused-code branch July 17, 2018 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anntzer anntzer anntzer approved these changes

@jklymak jklymak jklymak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@QuLogic @anntzer @jklymak @tacaswell