Skip to content

Remove pointless draw() at the end of static examples. #11679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 17, 2018

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Jul 17, 2018

draw() is completely unnecessary in these examples and only serves to
(mildly) confuse the reader.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

draw() is completely unnecessary in these examples and only serves to
(mildly) confuse the reader.
@ImportanceOfBeingErnest
Copy link
Member

Definitely! I did already remove some of those whenever I edited an example for other reasons.
Any idea how those made it into the examples? Was there a time when it was necessary?

@jklymak jklymak merged commit c85f821 into matplotlib:master Jul 17, 2018
@anntzer anntzer deleted the drawless branch July 17, 2018 12:55
@QuLogic QuLogic added this to the v3.0.0 milestone Nov 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants