Skip to content

FIX: make update-from also set the original face/edgecolor #11703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 27, 2018
Merged

FIX: make update-from also set the original face/edgecolor #11703

merged 2 commits into from
Jul 27, 2018

Conversation

jklymak
Copy link
Member

@jklymak jklymak commented Jul 19, 2018

PR Summary

Closes #11702...

patches.update_from wasn't setting _original_face/edgecolor

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@jklymak jklymak mentioned this pull request Jul 19, 2018
Closed
@jklymak jklymak force-pushed the fix-update-from-patches branch from ab09f2c to af43dae Compare July 19, 2018 04:31
anntzer
anntzer approved these changes Jul 20, 2018
View reviewed changes
Copy link
Contributor

@anntzer anntzer left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a better fix coming, but in the meantime this looks good.
(See #11710/#11711.)

This was referenced Jul 20, 2018
Open
Closed
@phobson phobson merged commit c552bdc into matplotlib:master Jul 27, 2018
@jklymak jklymak deleted the fix-update-from-patches branch July 27, 2018 15:24
@QuLogic QuLogic added this to the v3.0 milestone Jul 27, 2018
This was referenced Nov 3, 2018
Closed
Closed
@jklymak jklymak mentioned this pull request Dec 15, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phobson phobson phobson approved these changes

@anntzer anntzer anntzer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.

Setting alpha on legend handle changes patch color
4 participants
@jklymak @phobson @anntzer @QuLogic