Skip to content

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Jul 20, 2018

The Matplotlib test suite can be run from outside of the root git
directory, e.g. with

pytest --pyargs matplotlib.tests.test_backend_nbagg

(mplcairo explicitly relies on that to reuse the Matplotlib test suite).

To ensure this, find the example notebook relative to the path of the
test module, rather than relative to the current working directory.

(Marking as release critical to avoid causing difficulties to mplcairo's test suite, but I can always xfail that test instead from mplcairo otherwise.)

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

The Matplotlib test suite can be run from outside of the root git
directory, e.g. with

    pytest --pyargs matplotlib.tests.test_backend_nbagg

(mplcairo explicitly relies on that to reuse the Matplotlib test suite).

To ensure this, find the example notebook relative to the path of the
test module, rather than relative to the current working directory.
@anntzer anntzer added Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. topic: testing labels Jul 20, 2018
@anntzer anntzer added this to the v3.0 milestone Jul 20, 2018
Copy link
Member

@jklymak jklymak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable...

@QuLogic QuLogic merged commit 4bc1ca9 into matplotlib:master Jul 21, 2018
@anntzer anntzer deleted the nbaggtestcwd branch July 21, 2018 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. topic: testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants