DOC: fix broken link in inset-locator example #11717
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # optionally a location (loc) which accepts locations as codes, similar to | ||
| # `~matplotlib.axes.Axes.legend`. | ||
| # By default, the inset is offset by some points from the axes - this is | ||
| # The `.inset_locator`'s `~mpl_toolkits.axes_grid1.inset_axes` allows |
There was a problem hiding this comment.
If I'm not mistaken it should be
~mpl_toolkits.axes_grid1.inset_locator.inset_axes, which may probably be shortened to ~inset_locator.inset_axes. So I guess I was the one to actually make this mistake when I last edited that example.
|
It worked before because |
19d8be7 to
8661e9d
Compare
|
...a quite unfortunate decision to name it exactly like the existing one. |
|
The end goal is to deprecate axes_grid1, so I’m not concerned about the method having the same name. Same thing happened w twinx. |
8661e9d to
dec1c0e
Compare
dstansby
approved these changes
Jul 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Made a small error in #11026 with resolving a link in
examples/axes_grid1/inset_locator_demo.py. I think this fixes it...PR Checklist