Pin OSX CI to numpy<1.15 to unbreak the build. #11763
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timhoffm
approved these changes
Jul 24, 2018
|
Is this actually a bug w 1.15 or just a rounding change on Macos? if the later I’d just change the tolerance of the csd test. |
|
I don't know and don't really plan to investigate this :) |
|
OK, well, #11754 also has a tolerance fix for this (increased to .002). Given that the failing test is failing with .001, I think the problem is better solved by adjusting the tolerance on the test. |
|
Closed in lieu of #11767 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
1st commit: Trivial cleanups to travis setup.
2nd commit: Pin OSX CI to numpy<1.15 to unbreak the build.
PR Checklist