Skip to content

Pin OSX CI to numpy<1.15 to unbreak the build. #11763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Pin OSX CI to numpy<1.15 to unbreak the build. #11763

wants to merge 2 commits into from

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Jul 24, 2018

PR Summary

1st commit: Trivial cleanups to travis setup.
2nd commit: Pin OSX CI to numpy<1.15 to unbreak the build.

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer anntzer added the Build label Jul 24, 2018
@anntzer anntzer mentioned this pull request Jul 24, 2018
Merged
@jklymak
Copy link
Member

jklymak commented Jul 24, 2018

Is this actually a bug w 1.15 or just a rounding change on Macos? if the later I’d just change the tolerance of the csd test.

@anntzer
Copy link
Contributor Author

anntzer commented Jul 24, 2018

I don't know and don't really plan to investigate this :)

@jklymak
Copy link
Member

jklymak commented Jul 24, 2018

OK, well, #11754 also has a tolerance fix for this (increased to .002). Given that the failing test is failing with .001, I think the problem is better solved by adjusting the tolerance on the test.

@tacaswell tacaswell added this to the v3.0 milestone Jul 24, 2018
@jklymak
Copy link
Member

jklymak commented Jul 24, 2018

Closed in lieu of #11767

@jklymak jklymak closed this Jul 24, 2018
@anntzer anntzer self-assigned this Jul 24, 2018
@anntzer anntzer deleted the travis branch May 30, 2019 14:28
@anntzer anntzer removed their assignment May 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
Build
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@anntzer @jklymak @timhoffm @tacaswell