-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Correct errors in documentation #11770
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -39,7 +39,7 @@ API Changes for 3.0.0 | |||
Drop support for python 2 | |||
------------------------- | |||
|
|||
Matplotlib 3 only supports python 3.5 and higher | |||
Matplotlib 3 only supports python 3.5 and higher. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added on some minor grammar changes to your PR, but I think this sentence doesn't need the . (and Python should be capitalized).
doc/api/animation_api.rst
Outdated
time. When using blitting (by passing ``blit=True``) the core loop of | ||
`FuncAnimation` gets a bit more complicated :: | ||
time. When using blitting (by passing ``blit=True``), the core loop of | ||
`FuncAnimation` gets a bit more complicated. :: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be a colon, if anything here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what should be a colon?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The period. The sentence is implicitly carried on in the code below. I'd actually just leave w/o the period or colon, but a period is incorrect.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please refrain from doing copy-editting via github comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
... its a copy-edit PR. How would you like the copy editing corrected? Just force-push?
There seem to be a conflict, please backport manually |
Thanks @tlevine ! Congratulations on your first Matplotlib contribution 🎉 . Hopefully we will hear from you again! |
PR Summary
I corrected three errors in documentation: two missing periods, and one misspelled word.