Skip to content

Correct errors in documentation #11770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 26, 2018
Merged

Correct errors in documentation #11770

merged 5 commits into from
Jul 26, 2018

Conversation

tlevine
Copy link

@tlevine tlevine commented Jul 25, 2018

PR Summary

I corrected three errors in documentation: two missing periods, and one misspelled word.

@@ -39,7 +39,7 @@ API Changes for 3.0.0
Drop support for python 2
-------------------------

Matplotlib 3 only supports python 3.5 and higher
Matplotlib 3 only supports python 3.5 and higher.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added on some minor grammar changes to your PR, but I think this sentence doesn't need the . (and Python should be capitalized).

time. When using blitting (by passing ``blit=True``) the core loop of
`FuncAnimation` gets a bit more complicated ::
time. When using blitting (by passing ``blit=True``), the core loop of
`FuncAnimation` gets a bit more complicated. ::
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be a colon, if anything here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what should be a colon?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The period. The sentence is implicitly carried on in the code below. I'd actually just leave w/o the period or colon, but a period is incorrect.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please refrain from doing copy-editting via github comment.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... its a copy-edit PR. How would you like the copy editing corrected? Just force-push?

@tacaswell tacaswell added this to the v2.2.3 milestone Jul 26, 2018
@tacaswell tacaswell merged commit 1e4d6e1 into matplotlib:master Jul 26, 2018
@lumberbot-app
Copy link

lumberbot-app bot commented Jul 26, 2018

There seem to be a conflict, please backport manually

@tacaswell
Copy link
Member

Thanks @tlevine ! Congratulations on your first Matplotlib contribution 🎉 . Hopefully we will hear from you again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants