Fix collections import warnings for Python 3.7 #11786
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jklymak
approved these changes
Jul 28, 2018
|
damn, missed my chance to contribute again! One of these days ;) |
|
(btw, scikit-learn now raises deprecation warnings as errors during CI so that's where this is from) |
|
Sorry, didn't want to steal your contribution. Since nothing happend for some days and 3.0 is closing in, I worte the PR myself. Anyway, thanks a lot for the hint on the warnings. Also, there's still enough to contribute to matplotlib. We won't run out of topics for the time being 😄 . |
|
@meeseekdev backport to v2.2.x |
|
@meeseeksdev backport to v2.2.x |
|
There seem to be a conflict, please backport manually |
Closed
tacaswell
pushed a commit
to tacaswell/matplotlib
that referenced
this pull request
Sep 5, 2019
Fix collections import warnings for Python 3.7 Put try...except blocks in to support py27
QuLogic
added a commit
that referenced
this pull request
Sep 8, 2019
…-v2.2.x Merge pull request #11786 from timhoffm/collections-abc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This is in continuation of #11733.
As @amueller pointed out on gitter, there were still some abstract base classes imported via
collectionsinstead ofcollections.abc.