changed warning in animation #11828
Merged
changed warning in animation #11828
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dstansby
reviewed
Aug 9, 2018
lib/matplotlib/animation.py
Outdated
| @@ -1124,7 +1124,8 @@ class to use, such as 'ffmpeg'. If ``None``, defaults to | |||
| extra_args=extra_args, | |||
| metadata=metadata) | |||
| else: | |||
| _log.warning("MovieWriter %s unavailable.", writer) | |||
| _log.warning("MovieWriter {} unavailable. Using {} \ | |||
There was a problem hiding this comment.
Can this be "Trying to use" instead, because the following code block can still raise an error.
fabf887 to
eb96a21
Compare
tacaswell
reviewed
Aug 9, 2018
lib/matplotlib/animation.py
Outdated
| @@ -1124,7 +1124,8 @@ class to use, such as 'ffmpeg'. If ``None``, defaults to | |||
| extra_args=extra_args, | |||
| metadata=metadata) | |||
| else: | |||
| _log.warning("MovieWriter %s unavailable.", writer) | |||
| _log.warning("MovieWriter {} unavailable. Trying to use {} \ | |||
There was a problem hiding this comment.
Our standard style is to use
some_function("text"
"text")rather than \
tacaswell
approved these changes
Aug 9, 2018
eb96a21 to
1e00655
Compare
|
Changed. |
dopplershift
approved these changes
Aug 10, 2018
anntzer
reviewed
Aug 10, 2018
| @@ -1124,7 +1124,8 @@ class to use, such as 'ffmpeg'. If ``None``, defaults to | |||
| extra_args=extra_args, | |||
| metadata=metadata) | |||
| else: | |||
| _log.warning("MovieWriter %s unavailable.", writer) | |||
| _log.warning("MovieWriter {} unavailable. Trying to use {} " | |||
| "instead.".format(writer, writers.list()[0])) | |||
There was a problem hiding this comment.
Please use (a) _log.warning("... %s ...", arg) instead of (b) _log.warning("... {} ...".format(arg)). This is not only a matter of optimization (as the logging docs suggest -- in fact I'd say the cost of the formatting is pretty negligible here), but also because (b) will fail if arg contains a percent sign (because `_log.warning will then try to %-format the string).
Edit: Too bad it looks like there is no pycodestyle check for this(?)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From #11792.
The warning message when the writer chosen is not available didn't say that another writer is used instead. That can be confusing and it is changed in this pr.