Skip to content

Remove unnecessary use of nose. #11843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 11, 2018
Merged

Remove unnecessary use of nose. #11843

merged 1 commit into from
Aug 11, 2018

Conversation

QuLogic
Copy link
Member

@QuLogic QuLogic commented Aug 11, 2018

PR Summary

As in title. Fixes #11842.

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • [N/A] New features are documented, with examples if plot related
  • [N/A] Documentation is sphinx and numpydoc compliant
  • [N/A] Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • [N/A] Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@QuLogic QuLogic added this to the v3.0 milestone Aug 11, 2018
jklymak
jklymak approved these changes Aug 11, 2018
View reviewed changes
Copy link
Member

@jklymak jklymak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had no idea this had anything to do w nose. Thanks for the quick fix.

@tacaswell tacaswell merged commit 6c020e8 into matplotlib:master Aug 11, 2018
@QuLogic QuLogic deleted the no-nose branch August 11, 2018 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jklymak jklymak jklymak approved these changes

Assignees
No one assigned
Labels
topic: testing
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@QuLogic @jklymak @tacaswell