Skip to content

Use Format_ARGB32_Premultiplied instead of RGBA8888 for Qt backends. #11845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 13, 2018
Merged

Use Format_ARGB32_Premultiplied instead of RGBA8888 for Qt backends. #11845

merged 1 commit into from
Aug 13, 2018

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Aug 12, 2018

I missed the fact that support for the latter was only added in Qt5.2
and is thus unavailable in Qt4.

Move the supporting helper functions from backend_cairo to cbook.

Fixes part (2) of #11844.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer
Use Format_ARGB32_Premultiplied instead of RGBA8888 for Qt backends.
1acad5c 
I missed the fact that support for the latter was only added in Qt5.2
and is thus unavailable in Qt4.

Move the supporting helper functions from backend_cairo to cbook.
@anntzer anntzer added the Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. label Aug 12, 2018
@anntzer anntzer added this to the v3.0 milestone Aug 12, 2018
@timhoffm timhoffm merged commit b9b02f1 into matplotlib:master Aug 13, 2018
@anntzer anntzer deleted the qt4formatargb32 branch August 13, 2018 19:32
@timhoffm timhoffm mentioned this pull request Sep 5, 2018
Merged
6 tasks
@inxp inxp mentioned this pull request Dec 11, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jklymak jklymak jklymak approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@anntzer @jklymak @timhoffm