example file for making a bar of pie chart #11865

pjk645-zz · 2018-08-16T16:33:10Z

PR Summary

PR Checklist

Has Pytest style unit tests
Code is PEP 8 compliant
New features are documented, with examples if plot related
Documentation is sphinx and numpydoc compliant
Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

jklymak · 2018-08-16T16:41:16Z

examples/pie_and_polar_charts/bar_of_pie.py

@@ -0,0 +1,97 @@
+"""
+=========


This will fail to build because the = must be the right length...

I was parroting other examples. What is the correct length?

As long as the title (or longer I think is OK)

jklymak · 2018-08-16T16:41:43Z

examples/pie_and_polar_charts/bar_of_pie.py

+bar_height = sum([item.get_height() for item in ax2.patches])
+
+# draw top connecting line
+x = r*np.cos(math.pi/180*theta2)+center[0]


Just use np.pi to save the math import.

falke8 will complain about the spacing here. r * np.cos(np.pi / 180 * theta2) + center[0]. Yes, its arbitrary, but its a good to have a standard so code looks the same throughout. http://flake8.pycqa.org/en/latest/user/error-codes.html

Okay, I made the changes. I ran flake8 and it didn't seem to care about the math formatting. Just an fyi.

update on that, I think it checks for consistency: when there were no spaces in the math it was happy. Then when I put spaces around most mathematical operators it wanted them around all of them and was spitting out problems.

jklymak

Thanks a lot for this. It looks like it'll be great. Looks like it'll take a couple of tries to pass the CI tests. Look under Travis CI for flake8 errors (or install flake8 and run flake8 examples/pie_and_polar_charts/bar_of_pie.py. Note that to pass Flake8, you'll have to add an exception to .flake8 for E402 because this code has an import near the bottom. And look under the CI for the doc builds for errors and to make sure your example looks the way you'd like.

Please use a more descriptive title, and a bit of description in the PR description.

Thanks again!

pjk645-zz · 2018-08-16T19:22:17Z

I'm not sure why this is failing the Travis CI. Anyone have any ideas? It is passing flake8 on my computer except for the E402 exception.

jklymak · 2018-08-16T19:34:49Z

./examples/pie_and_polar_charts/bar_of_pie.py:88:1: E402 module level import not at top of file
E402 module level import not at top of file

You need to add the exception in .flake8 for this file.

Otherwise looks good.

https://12490-1385122-gh.circle-artifacts.com/0/home/circleci/project/doc/build/html/gallery/pie_and_polar_charts/bar_of_pie.html#sphx-glr-gallery-pie-and-polar-charts-bar-of-pie-py

pjk645-zz · 2018-08-16T19:49:12Z

Okay, thanks. I didn't pick up on that earlier.

jklymak · 2018-08-16T19:51:10Z

.flake8

@@ -6,6 +6,7 @@ ignore =
    E111, E114, E115, E116, E122, E124, E125, E127, E128, E129, E131,
    E265, E266,
    E305, E306,
+    E402,


Not here - add a per-file exception. See the other example files below...

jklymak

Thanks a lot. Approve conditional on CI passing...

timhoffm

Looks good. Anyone can merge after CI pass. Maybe the commits should be squashed.

jklymak · 2018-08-16T20:57:41Z

@pjk645 one more chore and then you'll have done it all..

First, back your branch up (git checkout bar_of_pie; git checkout -b bar-of-pie-backup; git checkout bar_of_pie)

Run git log and find the last commit before your first commit. Copy the commit id (i.e. df545a0433) and do:

git rebase -i xxxxxxxxxxx

Your editor should open and you "pick" the first commit and "squash" the following five entries. Save that file, and then the editor will open again and you can edit the single commit message.

Then git push origin bar_of_pie --force (the --force is why we back up just in case we make a mistake).

pjk645-zz · 2018-08-16T21:18:19Z

Hopefully, I did that correctly...

Thanks for the guidance

lumberbot-app · 2018-08-16T23:06:34Z

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

Checkout backport branch and update it.

$ git checkout v2.2.3-doc
$ git pull

Cherry pick the first parent branch of the this PR on top of the older branch:

$ git cherry-pick -m1 93879f8c557358b4e34212c2ee39c6f5bc5692d7

You will likely have some merge/cherry-pick conflict here, fix them and commit:

$ git commit -am 'Backport PR #11865: example file for making a bar of pie chart'

Push to a named branch :

git push YOURFORK v2.2.3-doc:auto-backport-of-pr-11865-on-v2.2.3-doc

Create a PR against branch v2.2.3-doc, I would have named this PR:

"Backport PR #11865 on branch v2.2.3-doc"

And apply the correct labels and milestones.

Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon!

If these instruction are inaccurate, feel free to suggest an improvement.

jklymak · 2018-08-16T23:07:01Z

Thanks a lot for your patience with the process @pjk645 and congrats on your first contribution!

jklymak · 2018-08-16T23:07:57Z

OK, I don't feel this is so urgent as to go through the backport rigamarole. Undoubtably just .flake8, but...

pjk645-zz mentioned this pull request Aug 16, 2018

Adding "pie of pie" and "bar of pie" functionality #11858

Closed

jklymak reviewed Aug 16, 2018

View reviewed changes

jklymak added the Documentation label Aug 16, 2018

jklymak added this to the v2.2-doc milestone Aug 16, 2018

pjk645-zz changed the title ~~initial commit~~ example file for making a bar of pie chart Aug 16, 2018

jklymak requested changes Aug 16, 2018

View reviewed changes

jklymak approved these changes Aug 16, 2018

View reviewed changes

timhoffm reviewed Aug 16, 2018

View reviewed changes

initial commit, fixes to formatting and squashing of commits

70df299

pjk645-zz force-pushed the bar_of_pie branch from 31cb708 to 70df299 Compare August 16, 2018 21:17

jklymak merged commit 93879f8 into matplotlib:master Aug 16, 2018

lumberbot-app bot added the status: needs manual backport label Aug 16, 2018

jklymak removed the status: needs manual backport label Aug 16, 2018

jklymak modified the milestones: v2.2-doc, v3.1 Aug 16, 2018

QuLogic modified the milestones: v3.1, v3.0 Aug 17, 2018

pjk645-zz deleted the bar_of_pie branch August 19, 2018 20:53

timhoffm mentioned this pull request Aug 21, 2018

fix format of bar_of_pie example #11906

Merged

		@@ -0,0 +1,97 @@
		"""
		=========

Uh oh!

example file for making a bar of pie chart #11865

example file for making a bar of pie chart #11865

Uh oh!

Conversation

pjk645-zz commented Aug 16, 2018

PR Summary

PR Checklist

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jklymak left a comment

Choose a reason for hiding this comment

Uh oh!

pjk645-zz commented Aug 16, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jklymak commented Aug 16, 2018

Uh oh!

pjk645-zz commented Aug 16, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jklymak left a comment

Choose a reason for hiding this comment

Uh oh!

timhoffm left a comment

Choose a reason for hiding this comment

Uh oh!

jklymak commented Aug 16, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pjk645-zz commented Aug 16, 2018

Uh oh!

lumberbot-app bot commented Aug 16, 2018

Uh oh!

jklymak commented Aug 16, 2018

Uh oh!

jklymak commented Aug 16, 2018

Uh oh!

Uh oh!

pjk645-zz commented Aug 16, 2018 •

edited

Loading

jklymak commented Aug 16, 2018 •

edited

Loading