mathtext.py style fixes. #11868
Merged
mathtext.py style fixes. #11868
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The only non-trivial fix is a replacement of np.round to the builtin round (mostly because it helps squeezing a line withing 79 chars); np.round was introduced in 95fda79 to get consistent Py2/Py3 behavior but Py3 matches np.round anyways (Py2's builtin round rounds halfway away from zero, Py3's builtin round and np.round round to even). Builtin round is faster than np.round for scalars, too (not that it really matters).
timhoffm
approved these changes
Aug 16, 2018
phobson
approved these changes
Aug 16, 2018
|
side note: i just used python black on a library and oh man it did a good job. i realize that such blanket global changes aren't going to work with >260 PRs open. but holy cow it's impressive. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only non-trivial fix is a replacement of np.round to the builtin
round (mostly because it helps squeezing a line withing 79 chars);
np.round was introduced in 95fda79 to get consistent Py2/Py3 behavior
but Py3 matches np.round anyways (Py2's builtin round rounds halfway
away from zero, Py3's builtin round and np.round round to even).
Builtin round is faster than np.round for scalars, too (not that it
really matters).
PR Summary
PR Checklist