Skip to content

Style fixes. #11869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 17, 2018
Merged

Style fixes. #11869

merged 1 commit into from
Aug 17, 2018

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Aug 16, 2018

Let's kill some flake8-ignores...
(All changes should be "trivial".)

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer anntzer changed the title More style fixes. Style fixes. Aug 16, 2018
timhoffm
timhoffm approved these changes Aug 17, 2018
View reviewed changes
lib/matplotlib/backends/backend_svg.py Outdated
"""
Parameters
----------
file: writable text file-like object
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

space before colon: file : writable ...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, fixed

@anntzer
More style fixes.
d9c9d2b 
Let's kill some flake8-ignores...
@jklymak jklymak merged commit d7493a5 into matplotlib:master Aug 17, 2018
@jklymak
Copy link
Member

jklymak commented Aug 17, 2018

My only concern about these (aside from enabling anyone's OCD) is that they will entail a bunch of rebasing of older PRs (many of which very much need review).

@jklymak jklymak added this to the v3.1 milestone Aug 17, 2018
@anntzer anntzer deleted the style branch August 17, 2018 17:37
@QuLogic QuLogic modified the milestones: v3.1, v3.0 Aug 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@anntzer @jklymak @timhoffm @QuLogic