Skip to content

DOC: make ibm link go to doi not ieee site #11881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 19, 2018
Merged

DOC: make ibm link go to doi not ieee site #11881

merged 1 commit into from
Aug 19, 2018

Conversation

jklymak
Copy link
Member

@jklymak jklymak commented Aug 18, 2018

PR Summary

Just a quick follow up to #11799 to make the link go to the doi look up. We really should do this when possible because maintaining the canonical link becomes doi.org's problem, not ours. The link resolves to the same spot.

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@jklymak jklymak added this to the v2.2-doc milestone Aug 18, 2018
@QuLogic QuLogic merged commit e5d5d40 into matplotlib:master Aug 19, 2018
@lumberbot-app
Copy link

lumberbot-app bot commented Aug 19, 2018

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
$ git checkout v2.2.3-doc
$ git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
$ git cherry-pick -m1 e5d5d4028a03b315dc8c8d87e0680c6e3e57530c
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
$ git commit -am 'Backport PR #11881: DOC: make ibm link go to doi not ieee site'
  1. Push to a named branch :
git push YOURFORK v2.2.3-doc:auto-backport-of-pr-11881-on-v2.2.3-doc
  1. Create a PR against branch v2.2.3-doc, I would have named this PR:

"Backport PR #11881 on branch v2.2.3-doc"

And apply the correct labels and milestones.

Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon!

If these instruction are inaccurate, feel free to suggest an improvement.

QuLogic added a commit to QuLogic/matplotlib that referenced this pull request Aug 19, 2018
@QuLogic
Merge pull request matplotlib#11881 from jklymak/doc-colormap-doi
88d346f 
DOC: make ibm link go to doi not ieee site
@QuLogic QuLogic mentioned this pull request Aug 19, 2018
Merged
tacaswell pushed a commit to tacaswell/matplotlib that referenced this pull request Nov 9, 2018
@QuLogic @tacaswell
Merge pull request matplotlib#11881 from jklymak/doc-colormap-doi
c8f4fc7 
DOC: make ibm link go to doi not ieee site
@tacaswell tacaswell mentioned this pull request Nov 9, 2018
Merged
tacaswell pushed a commit to tacaswell/matplotlib that referenced this pull request Nov 10, 2018
@QuLogic @tacaswell
Merge pull request matplotlib#11881 from jklymak/doc-colormap-doi
dd99e8e 
DOC: make ibm link go to doi not ieee site
tacaswell added a commit that referenced this pull request Nov 10, 2018
@tacaswell
Merge pull request #12789 from tacaswell/backports_colormap
906f6ea 
DOC: Backport colormap documentation

Includes  #11905, #11799, #11881, and #12084
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
v2.2-doc
Development

Successfully merging this pull request may close these issues.
3 participants
@jklymak @timhoffm @QuLogic