Skip to content

Factor out a subprocess log-and-check helper. #11888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 20, 2018
Merged

Factor out a subprocess log-and-check helper. #11888

merged 1 commit into from
Aug 20, 2018

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Aug 19, 2018

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer anntzer force-pushed the subprocess-helper branch from 7e78b00 to c954f34 Compare August 19, 2018 19:13
NelleV
NelleV approved these changes Aug 20, 2018
View reviewed changes
Copy link
Member

@NelleV NelleV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @anntzer

@NelleV NelleV merged commit 10a981a into matplotlib:master Aug 20, 2018
@anntzer anntzer deleted the subprocess-helper branch August 20, 2018 15:15
jcalbert pushed a commit to jcalbert/matplotlib that referenced this pull request Aug 20, 2018
@NelleV
Merge pull request matplotlib#11888 from anntzer/subprocess-helper
5db6740 
Factor out a subprocess log-and-check helper.
@anntzer anntzer mentioned this pull request Sep 27, 2018
Closed
@QuLogic QuLogic added this to the v3.1 milestone Nov 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NelleV NelleV NelleV approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@anntzer @NelleV @timhoffm @QuLogic