-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Resolve backend in rcParams.__getitem__("backend"). #11896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
tacaswell
merged 12 commits into
matplotlib:master
from
anntzer:auto-backend-resolution
Aug 28, 2018
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
adfb193
Resolve backend in rcParams.__getitem__("backend").
anntzer ce0c5e0
TST: add a force to a use call to be safe
tacaswell adf696f
API: change type of matplotlib.rcParamsOrig from dict -> RcParams
tacaswell 1e8788d
FIX: when resolving the auto-backend also update rcParamsOrig
tacaswell ce04937
API: Do not have rc_file_defaults import resolve backends
tacaswell 7dffd5b
MNT: special case the handling of 'backend' in rc_context
tacaswell 07b6c90
MNT: RcParams.__setitem__ refuses to set the backend sentinel
tacaswell 2c1f52c
FIX: when calling use do not trigger auto-backend resolution
tacaswell 75cc617
MNT: special case 'backend' in rc_file
tacaswell aaab933
TST: add check at end of auto-fixture that backend is still agg
tacaswell a2bc1b9
DOC: do not point to pyplot from __init__.py
tacaswell ad91933
MNT: do not special-case backend in rc_file_defaults or rc_file
tacaswell File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The docstring for
mpl.use
says the use ofplt.switch_backend
is preferred overforce=True
; so why is the discouraged form being used in the tests?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The docstring should be updated (really there is no (actual) difference between use and switch_backend anymore after this PR (other than whether we silently or loudly fail or emit a warning) so I'd rather not point to switch_backend, but I know @tacaswell did add some pointers to it at some point so I'll let him decide.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing that note from the docstring is something on my to-do list that I did not get to.