Skip to content

Simplify linestyle and fillstyle reference docs. #11909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 22, 2018

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Aug 21, 2018

I don't know what's up with "cornflowerblue" but "tab:blue" is just as
good :)

xref #11908

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@afvincent
Copy link
Contributor

Not sure that tab:blue existed when the doc has been originally written ;).

@anntzer
Copy link
Contributor Author

anntzer commented Aug 21, 2018

sure but "blue" did...

@afvincent
Copy link
Contributor

Yep, and as "red" and "green", some people find such color a bit too aggressive to the eyes, while "cornflowerblue" is a bit more pastel-ish IIRC ^^.

@@ -9,30 +9,25 @@
:doc:`/gallery/lines_bars_and_markers/marker_fillstyle_reference`
and :doc:`/gallery/shapes_and_collections/marker_path` examples.
"""

import numpy as np
import matplotlib.pyplot as plt
from matplotlib.lines import Line2D


points = np.ones(5) # Draw 3 points for each line
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does draw 5 points and not 3 as the comment states, does it not?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... sure

I don't know what's up with "cornflowerblue" but "tab:blue" is just as
good :)
@jklymak jklymak merged commit d384595 into matplotlib:master Aug 22, 2018
@jklymak jklymak added this to the v3.1 milestone Aug 22, 2018
@anntzer anntzer deleted the styleref-docs branch August 22, 2018 17:09
@tacaswell
Copy link
Member

"cornflowerblue" is more whimsical.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants