Remove the system_monitor example. #11914
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It drives an animation in a fairly roundabout way (one should just use plt.pause() (as shown in animation_demo) if not using the animation framework), and the example title isn't particularly related to the content either. OTOH it is one of the oldest examples in the repo, dating back to the 12th overall commit :)
|
I kinda like this example.... |
|
Not going to fight about its removal (close the PR if you just want to say no), but I do think that the example is a bit silly... |
|
What's the purpose of the example? Clearly it's not about drawing bars. But:
That's a bit similar to https://matplotlib.org/devdocs/gallery/animation/animation_demo.html So the questions are:
If both are yes, we should keep it (and maybe rename it and add a description). If not, we should probably drop it. |
|
I'm in favor of removing it, so 👍 on this PR for me. |
NelleV
approved these changes
Sep 14, 2018
|
Thanks @tacaswell and @anntzer ! |
|
I think that this is something we should document how to do, but with more context, this should be covered in #4779 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It drives an animation in a fairly roundabout way (one should just use
plt.pause() (as shown in animation_demo) if not using the animation
framework), and the example title isn't particularly related to the
content either.
OTOH it is one of the oldest examples in the repo, dating back to the
12th overall commit :)
PR Summary
PR Checklist