-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
More docstring cleanup of Line2D. #11938
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
43b5c17
to
d62b5c4
Compare
``{'ind': pointlist}`` | ||
Where *pointlist* is the set of points within the radius. | ||
|
||
TODO: sort returned indices by distance |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
leave this out of the docstring? :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, it's been in there before. I didn't bother to decide if this should stay or be moved to a comment or be deleted completely.
Just checked: It's a comment by John D. Hunter from 2007. Anyone thinks this is still relevant?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's just leave it in for now, didn't notice it was already there.
lib/matplotlib/lines.py
Outdated
@@ -729,7 +748,15 @@ def _is_sorted(self, x): | |||
|
|||
@allow_rasterization | |||
def draw(self, renderer): | |||
"""Draw the Line with *renderer* unless visibility is *False*.""" | |||
""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would suggest just deleting this docstring and moving it (after adapting it) to Artist.draw
, subclasses will then inherit it (more accurately, inspect.getdoc (which e.g. pydoc and ipython's foo? use) will lookup the docstring in the super methods).
d62b5c4
to
376e577
Compare
Thanks @timhoffm |
PR Summary
This is a continuation of #11922.