cleared test_barbs[png] #11946
Closed
cleared test_barbs[png] #11946
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anntzer
requested changes
Aug 27, 2018
There was a problem hiding this comment.
Proposing to reject per #11526 (comment). Thank you for your contribution, but I think the problem was ill-posed to start with... Sorry!
|
No worries ill move onto another! |
|
Are we good to close now? |
|
Thank you guys!! |
|
@jaideep-seth Thank you for your work on this (even though it did not get merged). Hopefully we will hear from you again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
PR Checklist