Skip to content

cbook.iterable -> np.iterable. #11959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 29, 2018
Merged

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Aug 28, 2018

PR Summary

All's in the title. (The two functions have the same implementation.)

Note that the following lines in sankey.py seem just wrong:

        if labels != '' and getattr(labels, '__iter__', False):
            # np.iterable() isn't used because it would give True if labels is
            # a string

(str does have an __iter__).

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer
Copy link
Contributor Author

anntzer commented Aug 29, 2018

I don't think this qualifies as API change? (Unless we start labeling deprecations as such.)

@timhoffm
Copy link
Member

Ok. Do we have labels for deprecations and/or code cleanup?

@timhoffm timhoffm merged commit 70cef77 into matplotlib:master Aug 29, 2018
@anntzer anntzer deleted the iterableless branch August 29, 2018 16:29
@anntzer
Copy link
Contributor Author

anntzer commented Aug 29, 2018

I don't think so.

@anntzer anntzer mentioned this pull request Aug 29, 2018
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants