TST: Fix duplicate file usage when running in parallel. #11973
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the same filename is used for two tests in the same file, there's a possibility that one might overwrite the other when testing in parallel.
timhoffm
approved these changes
Aug 29, 2018
|
Do we de-duplicate the names when saving them out? |
|
No, there's no de-duplication because then you would lose a test result. But images are saved and compared sequentially, so duplicate names in a single test are safe. (I believe I did originally attempt to parametrize |
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Aug 29, 2018
…ing in parallel.
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Aug 29, 2018
…ing in parallel.
tacaswell
added a commit
that referenced
this pull request
Aug 30, 2018
…973-on-v2.2.x Backport PR #11973 on branch v2.2.x
tacaswell
added a commit
that referenced
this pull request
Aug 30, 2018
…973-on-v3.0.x Backport PR #11973 on branch v3.0.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
If the same filename is used for two tests in the same file, there's a
possibility that one might overwrite the other when testing in parallel.
PR Checklist