Skip to content

Cleanup some axes_grid1 examples #11997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 14, 2018

Conversation

timhoffm
Copy link
Member

@timhoffm timhoffm commented Sep 2, 2018

PR Summary

This adapts some examples to current code style recommendations.

PR Checklist

@timhoffm timhoffm force-pushed the axesgrid_example_cleanup branch from dd11f6b to d1ae685 Compare September 2, 2018 08:12
@timhoffm
Copy link
Member Author

timhoffm commented Sep 2, 2018

By the way, AxesGrid is an alias to ImageGrid. The titles use the former while the code uses the latter. What's the reason behind this? IMO this should be unified, posibly to just use ImageGrid?

@NelleV
Copy link
Member

NelleV commented Sep 7, 2018

I'm going to close and reopen to retrigger appveyor

@NelleV NelleV closed this Sep 7, 2018
@NelleV NelleV reopened this Sep 7, 2018
@tacaswell tacaswell added this to the v3.1 milestone Sep 7, 2018
@anntzer
Copy link
Contributor

anntzer commented Sep 14, 2018

By the way, AxesGrid is an alias to ImageGrid. The titles use the former while the code uses the latter. What's the reason behind this? IMO this should be unified, posibly to just use ImageGrid?

Looks like AxesGrid was the original name and it was renamed to ImageGrid in d789c41 keeping the old alias. Agree with killing one of them :p (but I think AxesGrid is a better name -- you can use them for other stuff than images, can't you?)

@anntzer
Copy link
Contributor

anntzer commented Sep 14, 2018

thanks!

@anntzer anntzer merged commit 848d9fc into matplotlib:master Sep 14, 2018
@timhoffm timhoffm deleted the axesgrid_example_cleanup branch September 15, 2018 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants