FIX: fallback text renderer to fig._cachedRenderer, if none found #12012
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Closes #10874. See also #11004, and #10881. This is a more general backstop than the ticking fixes being proposed in #10874.
If a text obejct is created, but never drawn, its renderer never gets set (
self._renderer
). Subsequnet calls toself.get_window_extent()
that do not specify the renderer fail withRuntimeError('Cannot get window extent w/o renderer')
.Here I propose that we fall back on the cached renderer for the figure.
Test code:
PR Checklist