Skip to content

Fix deprecation check in wx Timer. #12023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 5, 2018
Merged

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Sep 5, 2018

Otherwise, breaks e.g. examples/animation/strip_chart.py and likely most
of the animation framework, which calls Timer() with no arguments.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

Otherwise, breaks e.g. examples/animation/strip_chart.py and likely most
of the animation framework, which calls Timer() with no arguments.
@anntzer anntzer added the Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. label Sep 5, 2018
@anntzer anntzer added this to the v3.0 milestone Sep 5, 2018
@QuLogic QuLogic merged commit 9ce6fbb into matplotlib:master Sep 5, 2018
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Sep 5, 2018
@anntzer anntzer deleted the wxtimer branch September 5, 2018 20:00
timhoffm added a commit that referenced this pull request Sep 5, 2018
…023-on-v3.0.x

Backport PR #12023 on branch v3.0.x (Fix deprecation check in wx Timer.)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants