Skip to content

Backport PR #11971 on branch v3.0.x (FIX: use cached renderer on Legend.get_window_extent) #12064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 7, 2018
Merged

Backport PR #11971 on branch v3.0.x (FIX: use cached renderer on Legend.get_window_extent) #12064

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions lib/matplotlib/legend.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -977,9 +977,11 @@ def get_title(self):
'Return the `.Text` instance for the legend title.'
return self._legend_title_box._text

def get_window_extent(self, *args, **kwargs):
def get_window_extent(self, renderer=None):
'Return extent of the legend.'
return self._legend_box.get_window_extent(*args, **kwargs)
if renderer is None:
renderer = self.figure._cachedRenderer
return self._legend_box.get_window_extent(renderer=renderer)

def get_tightbbox(self, renderer):
"""
Expand Down
11 changes: 11 additions & 0 deletions lib/matplotlib/tests/test_legend.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -510,6 +510,17 @@ def test_legend_proper_window_extent():
assert pytest.approx(x01*2, 0.1) == x02


def test_window_extent_cached_renderer():
fig, ax = plt.subplots(dpi=100)
ax.plot(range(10), label='Aardvark')
leg = ax.legend()
leg2 = fig.legend()
fig.canvas.draw()
# check that get_window_extent will use the cached renderer
leg.get_window_extent()
leg2.get_window_extent()


def test_legend_title_fontsize():
# test the title_fontsize kwarg
fig, ax = plt.subplots()
Expand Down