Update backend_qt5agg to fix PySide2 mem issues #12092
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pyside2 seems to have the same issue as PySide where the QImage data reference is incorrect and needs to be adjusted for the Python garbage collector.
anntzer
approved these changes
Sep 11, 2018
jklymak
approved these changes
Sep 11, 2018
|
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon! If these instruction are inaccurate, feel free to suggest an improvement. |
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Sep 11, 2018
jklymak
added a commit
to jklymak/matplotlib
that referenced
this pull request
Sep 11, 2018
6 tasks
jklymak
added a commit
that referenced
this pull request
Sep 11, 2018
…092-on-v3.0.x Backport PR #12092 on branch v3.0.x (Update backend_qt5agg to fix PySide2 mem issues)
anntzer
added a commit
that referenced
this pull request
Sep 11, 2018
…2.2.x Backport PR #12092: Update backend_qt5agg to fix PySide2 mem issues
|
Thanks @simon-kraeusel ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pyside2 seems to have the same issue as PySide where the QImage data reference is incorrect and needs to be adjusted for the Python garbage collector.
Closes #12089
PR Summary
PR Checklist