Skip to content

MNT: re-add cbook import art3d #12122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 14, 2018
Merged

MNT: re-add cbook import art3d #12122

merged 1 commit into from
Sep 14, 2018

Conversation

jklymak
Copy link
Member

@jklymak jklymak commented Sep 14, 2018 •
edited
Loading

PR Summary

#12032 removed a cbook too many; mplot3d tests fail w/o this...

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@jklymak jklymak added the Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. label Sep 14, 2018
@jklymak jklymak added this to the v3.1 milestone Sep 14, 2018
@dopplershift
Copy link
Contributor

Really weird that it passed, then broke CI.

@jklymak
Copy link
Member Author

jklymak commented Sep 14, 2018

#12049 added the cbook call, #12032 removed the cbook import, and they were both just merged today. So I think this is the right fix.

@dopplershift
Copy link
Contributor

Ok, that makes sense. Definitely seems like the right fix.

@tacaswell tacaswell merged commit b99e636 into matplotlib:master Sep 14, 2018
@jklymak jklymak deleted the fix-imports branch September 14, 2018 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dopplershift dopplershift dopplershift approved these changes

Assignees
No one assigned
Labels
Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.
Projects
None yet
Milestone
v3.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jklymak @dopplershift @tacaswell