Skip to content

Backports for 3.0 #12129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 16, 2018
Merged

Backports for 3.0 #12129

merged 6 commits into from
Sep 16, 2018

Conversation

tacaswell
Copy link
Member

PR Summary

Does the backport and moves the docs around.

@tacaswell tacaswell added this to the v3.0 milestone Sep 15, 2018
NelleV and others added 2 commits September 15, 2018 16:27
Update doc/conf.py to avoid warnings with (future) sphinx 1.8.
BLD: Propagate changes to backend loading to setup/setupext.
@tacaswell tacaswell changed the title Backport 12128 Backports for 3.0 Sep 15, 2018
@tacaswell
Copy link
Member Author

This also backports #11928 and #11962

FIX: make sure all ticks show up for colorbar minor tick
@tacaswell
Copy link
Member Author

Also #12099

@tacaswell tacaswell closed this Sep 15, 2018
@tacaswell tacaswell reopened this Sep 15, 2018
@tacaswell
Copy link
Member Author

Sigh, I swear I can use a mouse, closed/opened because I missed tho 'comment' button....

@tacaswell tacaswell added the Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. label Sep 15, 2018
@tacaswell
Copy link
Member Author

sigh, down the sphinx rabbit hole!

@tacaswell
Copy link
Member Author

tacaswell commented Sep 15, 2018

which of course I can not reproduce locally...

[edit: because I was on the wrong branch]

In matplotlib#12110 only the pinning got backported, not adding mathmpl back
into conf.py
@tacaswell
Copy link
Member Author

The issue with the failed backport was that #12109 and #11928 were backported in the wrong order.

@tacaswell
Copy link
Member Author

As this is backports, going to self-merge.

@tacaswell tacaswell merged commit 3831542 into matplotlib:v3.0.x Sep 16, 2018
@tacaswell tacaswell deleted the backport_12128 branch September 16, 2018 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants